Impaczus/rpcs3
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Use string_view for log params

Browse Source
This commit is contained in:
Megamouse
2025-05-06 09:15:05 +02:00
parent aa79afd7ae
commit fc3a905c90
4 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
rpcs3/rpcs3.cpp
+1 -1
View File
@@ -303,7 +303,7 @@ struct fatal_error_listener final : logs::listener
public: public:
~fatal_error_listener() override = default; ~fatal_error_listener() override = default;
void log(u64 /*stamp*/, const logs::message& msg, const std::string& prefix, const std::string& text) override void log(u64 /*stamp*/, const logs::message& msg, std::string_view prefix, std::string_view text) override
{ {
if (msg == logs::level::fatal || (msg == logs::level::always && m_log_always)) if (msg == logs::level::fatal || (msg == logs::level::always && m_log_always))
{ {
rpcs3/rpcs3qt/log_frame.cpp
+1 -1
View File
@@ -50,7 +50,7 @@ struct gui_listener : logs::listener
{ {
} }
void log(u64 stamp, const logs::message& msg, const std::string& prefix, const std::string& text) override void log(u64 stamp, const logs::message& msg, std::string_view prefix, std::string_view text) override
{ {
Q_UNUSED(stamp) Q_UNUSED(stamp)
rpcs3/util/logs.cpp
+4 -4
View File
@@ -118,7 +118,7 @@ namespace logs
~file_listener() override = default; ~file_listener() override = default;
void log(u64 stamp, const message& msg, const std::string& prefix, const std::string& text) override; void log(u64 stamp, const message& msg, std::string_view prefix, std::string_view text) override;
void sync() override void sync() override
{ {
@@ -138,7 +138,7 @@ namespace logs
~root_listener() override = default; ~root_listener() override = default;
// Encode level, current thread name, channel name and write log message // Encode level, current thread name, channel name and write log message
void log(u64, const message&, const std::string&, const std::string&) override void log(u64, const message&, std::string_view, std::string_view) override
{ {
// Do nothing // Do nothing
} }
@@ -251,7 +251,7 @@ namespace logs
{ {
std::lock_guard lock(g_mutex); std::lock_guard lock(g_mutex);
auto found = get_logger()->channels.equal_range(ch_name); const auto found = get_logger()->channels.equal_range(ch_name);
if (found.first != found.second) if (found.first != found.second)
{ {
@@ -771,7 +771,7 @@ logs::file_listener::file_listener(const std::string& path, u64 max_size)
file_writer::log("\xEF\xBB\xBF", 3); file_writer::log("\xEF\xBB\xBF", 3);
} }
void logs::file_listener::log(u64 stamp, const logs::message& msg, const std::string& prefix, const std::string& _text) void logs::file_listener::log(u64 stamp, const logs::message& msg, std::string_view prefix, std::string_view _text)
{ {
/*constinit thread_local*/ std::string text; /*constinit thread_local*/ std::string text;
text.reserve(50000); text.reserve(50000);
rpcs3/util/logs.hpp
+1 -1
View File
@@ -79,7 +79,7 @@ namespace logs
virtual ~listener(); virtual ~listener();
// Process log message // Process log message
virtual void log(u64 stamp, const message& msg, const std::string& prefix, const std::string& text) = 0; virtual void log(u64 stamp, const message& msg, std::string_view prefix, std::string_view text) = 0;
// Flush contents (file writer) // Flush contents (file writer)
virtual void sync(); virtual void sync();