Impaczus/rpcs3
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

rsx/zcull: Rename write_enabled to surface_active to make the meaning clear

Browse Source
This commit is contained in:
kd-11
2026-01-11 23:26:49 +03:00
committed by kd-11
parent f45742df52
commit c199a96dac
2 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
rpcs3/Emu/RSX/RSXZCULL.cpp
+4 -4
View File
@@ -82,7 +82,7 @@ namespace rsx
{ {
// NOTE: Only enable host queries if pixel count is active to save on resources // NOTE: Only enable host queries if pixel count is active to save on resources
// Can optionally be enabled for either stats enabled or zpass enabled for accuracy // Can optionally be enabled for either stats enabled or zpass enabled for accuracy
const bool data_stream_available = zpass_count_enabled; // write_enabled && (zpass_count_enabled || stats_enabled); const bool data_stream_available = zpass_count_enabled; // surface_active && (zpass_count_enabled || stats_enabled);
if (host_queries_active && !data_stream_available) if (host_queries_active && !data_stream_available)
{ {
// Stop // Stop
@@ -106,7 +106,7 @@ namespace rsx
void ZCULL_control::set_status(class ::rsx::thread* ptimer, bool surface_active, bool zpass_active, bool zcull_stats_active, bool flush_queue) void ZCULL_control::set_status(class ::rsx::thread* ptimer, bool surface_active, bool zpass_active, bool zcull_stats_active, bool flush_queue)
{ {
write_enabled = surface_active; surface_active = surface_active;
zpass_count_enabled = zpass_active; zpass_count_enabled = zpass_active;
stats_enabled = zcull_stats_active; stats_enabled = zcull_stats_active;
@@ -340,14 +340,14 @@ namespace rsx
} }
break; break;
case CELL_GCM_ZCULL_STATS3: case CELL_GCM_ZCULL_STATS3:
value = (value || !write_enabled || !stats_enabled) ? 0 : u16{ umax }; value = (value || !surface_active || !stats_enabled) ? 0 : u16{ umax };
break; break;
case CELL_GCM_ZCULL_STATS2: case CELL_GCM_ZCULL_STATS2:
case CELL_GCM_ZCULL_STATS1: case CELL_GCM_ZCULL_STATS1:
case CELL_GCM_ZCULL_STATS: case CELL_GCM_ZCULL_STATS:
default: default:
// Not implemented // Not implemented
value = (write_enabled && stats_enabled) ? -1 : 0; value = (surface_active && stats_enabled) ? -1 : 0;
break; break;
} }
rpcs3/Emu/RSX/RSXZCULL.h
+1 -1
View File
@@ -109,7 +109,7 @@ namespace rsx
protected: protected:
bool unit_enabled = false; // The ZCULL unit is on bool unit_enabled = false; // The ZCULL unit is on
bool write_enabled = false; // A surface in the ZCULL-monitored tile region has been loaded for rasterization bool surface_active = false; // A surface in the ZCULL-monitored tile region has been loaded for rasterization
bool stats_enabled = false; // Collecting of ZCULL statistics is enabled (not same as pixels passing Z test!) bool stats_enabled = false; // Collecting of ZCULL statistics is enabled (not same as pixels passing Z test!)
bool zpass_count_enabled = false; // Collecting of ZPASS statistics is enabled. If this is off, the counter does not increment bool zpass_count_enabled = false; // Collecting of ZPASS statistics is enabled. If this is off, the counter does not increment
bool host_queries_active = false; // The backend/host is gathering Z data for the ZCULL unit bool host_queries_active = false; // The backend/host is gathering Z data for the ZCULL unit