Impaczus/rpcs3
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

SPU: Move check_state() outside of mutex scope

Browse Source 
Can result in a deadlock in some cases, cpu flags are checked after this function as well anyways.
This commit is contained in:
Eladash
2020-06-04 14:27:23 +03:00
committed by Ivan
parent 314dc4c5de
commit c15b5f1eca
1 changed files with 0 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
rpcs3/Emu/Cell/SPUThread.cpp
-4
View File
@@ -3028,7 +3028,6 @@ bool spu_thread::stop_and_signal(u32 code)
if (!lv2_event_queue::check(queue)) if (!lv2_event_queue::check(queue))
{ {
check_state();
return ch_in_mbox.set_values(1, CELL_EINVAL), true; return ch_in_mbox.set_values(1, CELL_EINVAL), true;
} }
@@ -3036,7 +3035,6 @@ bool spu_thread::stop_and_signal(u32 code)
if (!queue->exists) if (!queue->exists)
{ {
check_state();
return ch_in_mbox.set_values(1, CELL_EINVAL), true; return ch_in_mbox.set_values(1, CELL_EINVAL), true;
} }
@@ -3065,7 +3063,6 @@ bool spu_thread::stop_and_signal(u32 code)
const auto data3 = static_cast<u32>(std::get<3>(event)); const auto data3 = static_cast<u32>(std::get<3>(event));
ch_in_mbox.set_values(4, CELL_OK, data1, data2, data3); ch_in_mbox.set_values(4, CELL_OK, data1, data2, data3);
queue->events.pop_front(); queue->events.pop_front();
check_state();
return true; return true;
} }
} }
@@ -3113,7 +3110,6 @@ bool spu_thread::stop_and_signal(u32 code)
} }
} }
check_state();
return true; return true;
} }