Impaczus/rpcs3
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

cellMusic: don't set current_track to umax on prev

Browse Source 
There's no reason to do that and it might cause OOB access elsewhere.
This commit is contained in:
Megamouse
2026-06-01 22:12:43 +02:00
parent 5fc7450865
commit 7c2bd56776
1 changed files with 2 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
rpcs3/Emu/Cell/Modules/cellMusicSelectionContext.cpp
+2 -3
View File
@@ -301,7 +301,7 @@ u32 music_selection_context::step_track(bool next)
{ {
// We are at the end of the playlist. // We are at the end of the playlist.
cellMusicSelectionContext.notice("step_track: No more tracks to play in playlist..."); cellMusicSelectionContext.notice("step_track: No more tracks to play in playlist...");
current_track = playlist.size() - 1; // NOTE: We could use size instead of size - 1 to allow to use PREV to play the last track again. current_track = ::size32(playlist) - 1; // NOTE: We could use size instead of size - 1 to allow to use PREV to play the last track again.
return umax; return umax;
} }
} }
@@ -312,7 +312,6 @@ u32 music_selection_context::step_track(bool next)
{ {
// We are at the start of the playlist. // We are at the start of the playlist.
cellMusicSelectionContext.notice("step_track: No more tracks to play in playlist..."); cellMusicSelectionContext.notice("step_track: No more tracks to play in playlist...");
current_track = umax;
return umax; return umax;
} }
@@ -337,7 +336,7 @@ u32 music_selection_context::step_track(bool next)
// Play the previous track. Start with the last track if we reached the start of the playlist. // Play the previous track. Start with the last track if we reached the start of the playlist.
if (current_track == 0) if (current_track == 0)
{ {
current_track = ::narrow<u32>(playlist.size() - 1); current_track = ::size32(playlist) - 1;
} }
else else
{ {