rsx: Optimize FIFO PUT masking

This commit is contained in:
Eladash
2019-09-29 20:23:52 +03:00
committed by kd-11
parent bcf8799079
commit 70b4ae6bd6
2 changed files with 12 additions and 4 deletions
+10 -2
View File
@@ -17,7 +17,7 @@ namespace rsx
{ {
m_internal_get += 4; m_internal_get += 4;
if (wait && read_put() == m_internal_get) if (wait && read_put<false>() == m_internal_get)
{ {
// NOTE: Only supposed to be invoked to wait for a single arg on command[0] (4 bytes) // NOTE: Only supposed to be invoked to wait for a single arg on command[0] (4 bytes)
// Wait for put to allow us to procceed execution // Wait for put to allow us to procceed execution
@@ -30,10 +30,18 @@ namespace rsx
} }
} }
template <bool full>
u32 FIFO_control::read_put() u32 FIFO_control::read_put()
{
if constexpr (!full)
{
return m_ctrl->put & ~3;
}
else
{ {
return m_ctrl->put.and_fetch(~3); return m_ctrl->put.and_fetch(~3);
} }
}
void FIFO_control::set_put(u32 put) void FIFO_control::set_put(u32 put)
{ {
@@ -65,7 +73,7 @@ namespace rsx
{ {
// Fast read with no processing, only safe inside a PACKET_BEGIN+count block // Fast read with no processing, only safe inside a PACKET_BEGIN+count block
if (m_remaining_commands && if (m_remaining_commands &&
m_internal_get != read_put()) m_internal_get != read_put<false>())
{ {
m_command_reg += m_command_inc; m_command_reg += m_command_inc;
m_args_ptr += 4; m_args_ptr += 4;
+1 -1
View File
@@ -131,7 +131,7 @@ namespace rsx
void inc_get(bool wait); void inc_get(bool wait);
void set_get(u32 get); void set_get(u32 get);
void set_put(u32 put); void set_put(u32 put);
u32 read_put(); template <bool = true> u32 read_put();
void read(register_pair& data); void read(register_pair& data);
inline bool read_unsafe(register_pair& data); inline bool read_unsafe(register_pair& data);