Impaczus/rpcs3
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

cellSaveData: Filter directory lists to allowed savedata directories

Browse Source 
Filters "." and "..", as well as possible wrong directories added by the user.
This commit is contained in:
Eladash
2020-03-13 17:34:15 +02:00
committed by Ivan
parent b21b4faca8
commit 5d78d81c00
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
rpcs3/Emu/Cell/Modules/cellSaveData.cpp
+3 -3
View File
@@ -107,12 +107,12 @@ static std::vector<SaveDataEntry> get_save_entries(const std::string& base_dir,
// get the saves matching the supplied prefix // get the saves matching the supplied prefix
for (auto&& entry : fs::dir(base_dir)) for (auto&& entry : fs::dir(base_dir))
{ {
if (!entry.is_directory || entry.name == "." || entry.name == "..") if (!entry.is_directory || sysutil_check_name_string(entry.name.c_str(), 1, CELL_SAVEDATA_DIRNAME_SIZE) != 0)
{ {
continue; continue;
} }
if (entry.name.substr(0, prefix.size()) != prefix) if (!entry.name.starts_with(prefix))
{ {
continue; continue;
} }
@@ -591,7 +591,7 @@ static NEVER_INLINE error_code savedata_op(ppu_thread& ppu, u32 operation, u32 v
// get the saves matching the supplied prefix // get the saves matching the supplied prefix
for (auto&& entry : fs::dir(base_dir)) for (auto&& entry : fs::dir(base_dir))
{ {
if (!entry.is_directory || entry.name == "." || entry.name == "..") if (!entry.is_directory || sysutil_check_name_string(entry.name.c_str(), 1, CELL_SAVEDATA_DIRNAME_SIZE) != 0)
{ {
continue; continue;
} }