Impaczus/rpcs3
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

gl: Fix face winding

Browse Source 
- Face winding is always calculated based off the top left corner
This commit is contained in:
kd-11
2017-11-18 17:23:25 +03:00
parent de5a4fe083
commit 07fe5f87ae
1 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
rpcs3/Emu/RSX/GL/GLGSRender.cpp
+8 -8
View File
@@ -140,24 +140,24 @@ namespace
GLenum front_face(rsx::front_face op) GLenum front_face(rsx::front_face op)
{ {
bool invert = (rsx::method_registers.shader_window_origin() == rsx::window_origin::bottom); //NOTE: RSX face winding is always based off of upper-left corner like vulkan, but GL is bottom left
//shader_window_origin register does not affect this
//verified with Outrun Online Arcade (window_origin::top) and DS2 (window_origin::bottom)
//correctness of face winding checked using stencil test (GOW collection shadows)
switch (op) switch (op)
{ {
case rsx::front_face::cw: return (invert ? GL_CCW : GL_CW); case rsx::front_face::cw: return GL_CCW;
case rsx::front_face::ccw: return (invert ? GL_CW : GL_CCW); case rsx::front_face::ccw: return GL_CW;
} }
fmt::throw_exception("Unsupported front face 0x%X" HERE, (u32)op); fmt::throw_exception("Unsupported front face 0x%X" HERE, (u32)op);
} }
GLenum cull_face(rsx::cull_face op) GLenum cull_face(rsx::cull_face op)
{ {
bool invert = (rsx::method_registers.shader_window_origin() == rsx::window_origin::top);
switch (op) switch (op)
{ {
case rsx::cull_face::front: return (invert ? GL_BACK : GL_FRONT); case rsx::cull_face::front: return GL_FRONT;
case rsx::cull_face::back: return (invert ? GL_FRONT : GL_BACK); case rsx::cull_face::back: return GL_BACK;
case rsx::cull_face::front_and_back: return GL_FRONT_AND_BACK; case rsx::cull_face::front_and_back: return GL_FRONT_AND_BACK;
} }
fmt::throw_exception("Unsupported cull face 0x%X" HERE, (u32)op); fmt::throw_exception("Unsupported cull face 0x%X" HERE, (u32)op);